Skip to content

Commit

Permalink
ADR011 light client extraction (first iteration) (#2423)
Browse files Browse the repository at this point in the history
* Initial draft

* Add object-safety related decisions

* More on object-safety

* Document proposal on downcasting support

* Special case AnyClient removal

* Ideas on splitting work

* Summarize rationale for Any* enums described in ADR003

* Address review feedback

* Apply suggestions from code review

Co-authored-by: Sean Chen <[email protected]>

* Add section on light client registry

* Long-lived branch

* Add section on domain types

* Proposal for handling light client specific code

* ADR table entry

* Add examples for light client specific module code

* Move `ClientState::client_def()` to `ClientReader::client_def()`

* Modify example describing need for client registry

* Add proposal to merge `ClientDef` into `ClientState`

* Add line about client registry reexporting concrete types

* Add .changelog entry

* Fix changelog links

* Add comments about object safe Protobuf trait

* Delete old comment regarding `Header::encode_any()`

Co-authored-by: Sean Chen <[email protected]>
  • Loading branch information
hu55a1n1 and seanchen1991 authored Jul 21, 2022
1 parent dbd748a commit c10bf7c
Show file tree
Hide file tree
Showing 5 changed files with 500 additions and 13 deletions.
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
- Fix serde implementations for ICS20 packet data structures
([#2330](https://github.com/informalsystems/ibc-rs/issues/2386)).
([#2386](https://github.com/informalsystems/ibc-rs/issues/2386)).
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
- Remove provided `Ics20Reader::get_channel_escrow_address()` implementation and make `cosmos_adr028_escrow_address()`
public.
([#2035](https://github.com/informalsystems/ibc-rs/issues/2387))
([#2387](https://github.com/informalsystems/ibc-rs/issues/2387))
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/ibc/2356-adr011.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Propose ADR011 for light client extraction.
([#2356](https://github.com/informalsystems/ibc-rs/pull/2356)).
23 changes: 12 additions & 11 deletions docs/architecture/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,16 @@ To suggest an ADR, please make use of the [ADR template](./adr-template.md) prov

## Table of Contents

| ADR \# | Description | Status |
| ------ | ----------- | ------ |
| [001](./adr-001-repo.md) | Repository structure for `ibc-rs` | Accepted |
| [002](./adr-002-ibc-relayer.md) | IBC Relayer in Rust | Accepted |
| [003](./adr-003-handler-implementation.md) | IBC handlers implementation | Accepted |
| [004](./adr-004-relayer-domain-decomposition.md) | Relayer domain decomposition | Accepted |
| [005](./adr-005-relayer-v0-implementation.md) | Relayer v0 implementation | Accepted |
| [006](./adr-006-hermes-v0.2-usecases.md) | Hermes v0.2.0 Use-Cases | Proposed |
| [007](./adr-007-error.md) | Error Management | Accepted |
| [008](./adr-008-ics20-implementation.md) | ICS20 implementation | Accepted |
| ADR \# | Description | Status |
|-----------------------------------------------------------|-------------------------------------------------------|----------|
| [001](./adr-001-repo.md) | Repository structure for `ibc-rs` | Accepted |
| [002](./adr-002-ibc-relayer.md) | IBC Relayer in Rust | Accepted |
| [003](./adr-003-handler-implementation.md) | IBC handlers implementation | Accepted |
| [004](./adr-004-relayer-domain-decomposition.md) | Relayer domain decomposition | Accepted |
| [005](./adr-005-relayer-v0-implementation.md) | Relayer v0 implementation | Accepted |
| [006](./adr-006-hermes-v0.2-usecases.md) | Hermes v0.2.0 Use-Cases | Proposed |
| [007](./adr-007-error.md) | Error Management | Accepted |
| [008](./adr-008-ics20-implementation.md) | ICS20 implementation | Accepted |
| [009](./adr-009-chain-endpoint-handle-standardization.md) | ChainEndpoint and ChainHandle methods standardization | Accepted |
| [010](./adr-010-unified-cli-arguments-hermes.md) | Unified approach for CLI arguments for Hermes v1.0.0 | Proposed |
| [010](./adr-010-unified-cli-arguments-hermes.md) | Unified approach for CLI arguments for Hermes v1.0.0 | Proposed |
| [011](./adr-011-light-client-crates-extraction.md) | Light client crates extraction | Proposed |
Loading

0 comments on commit c10bf7c

Please sign in to comment.