-
Notifications
You must be signed in to change notification settings - Fork 326
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ADR011 light client extraction (first iteration) (#2423)
* Initial draft * Add object-safety related decisions * More on object-safety * Document proposal on downcasting support * Special case AnyClient removal * Ideas on splitting work * Summarize rationale for Any* enums described in ADR003 * Address review feedback * Apply suggestions from code review Co-authored-by: Sean Chen <[email protected]> * Add section on light client registry * Long-lived branch * Add section on domain types * Proposal for handling light client specific code * ADR table entry * Add examples for light client specific module code * Move `ClientState::client_def()` to `ClientReader::client_def()` * Modify example describing need for client registry * Add proposal to merge `ClientDef` into `ClientState` * Add line about client registry reexporting concrete types * Add .changelog entry * Fix changelog links * Add comments about object safe Protobuf trait * Delete old comment regarding `Header::encode_any()` Co-authored-by: Sean Chen <[email protected]>
- Loading branch information
1 parent
dbd748a
commit c10bf7c
Showing
5 changed files
with
500 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
- Fix serde implementations for ICS20 packet data structures | ||
([#2330](https://github.com/informalsystems/ibc-rs/issues/2386)). | ||
([#2386](https://github.com/informalsystems/ibc-rs/issues/2386)). |
2 changes: 1 addition & 1 deletion
2
.changelog/unreleased/bug-fixes/ibc/2387-fix-get_channel_escrow_address.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
- Remove provided `Ics20Reader::get_channel_escrow_address()` implementation and make `cosmos_adr028_escrow_address()` | ||
public. | ||
([#2035](https://github.com/informalsystems/ibc-rs/issues/2387)) | ||
([#2387](https://github.com/informalsystems/ibc-rs/issues/2387)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- Propose ADR011 for light client extraction. | ||
([#2356](https://github.com/informalsystems/ibc-rs/pull/2356)). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.