Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot reach telemetry endpoint from another machine in the same network #1032

Closed
5 tasks done
andynog opened this issue Jun 1, 2021 · 0 comments · Fixed by #1033
Closed
5 tasks done

Cannot reach telemetry endpoint from another machine in the same network #1032

andynog opened this issue Jun 1, 2021 · 0 comments · Fixed by #1033
Assignees
@andynog
Labels
A: bug Admin: something isn't working I: telemetry Internal: related to Telemetry & metrics
Milestone
05.2021

Comments

@andynog
Copy link
Contributor

andynog commented Jun 1, 2021

Crate

telemetry

Summary of Bug

Testing the telemetry server, I could not reach the metric endpoint from another machine in the same network. This is important because Prometheus will probably be running on another machine.

Version

e4a6543

Steps to Reproduce

Run the relayer on one machine in the network with hermes start. Try to access the telemetry endpoint on another machine in the network e.g. if the hermes machine IP is 192.168.1.10, trying to access the endpoint http://192.168.1.10:3001/metrics won't work.

The reason for that is because the telemetry server (rouille) is hardcoded to localhost. Setting it to 0.0.0.0 fixes the issue.

Acceptance Criteria

Be able to access the telemetry endpoint from a different computer in the same subnet other than the relayer.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@andynog andynog added A: bug Admin: something isn't working I: telemetry Internal: related to Telemetry & metrics labels Jun 1, 2021
@andynog andynog added this to the 05.2021 milestone Jun 1, 2021
@andynog andynog self-assigned this Jun 1, 2021
andynog added a commit that referenced this issue Jun 1, 2021
@andynog
Fixing telemetry server listen host (#1032)
5346cc5
This was referenced Jun 1, 2021
Merged
Closed
romac added a commit that referenced this issue Jun 3, 2021
@andynog @romac
Add host parameter to telemetry config (#1033)
7171f0e 
* Fixing telemetry server listen host (#1032)

* Add `host` parameter for the telemetry server

* Gracefully exit when telemetry service fails to start

Co-authored-by: Romain Ruetschi <[email protected]>
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
@andynog @romac
Add host parameter to telemetry config (informalsystems#1033)
08f9999 
* Fixing telemetry server listen host (informalsystems#1032)

* Add `host` parameter for the telemetry server

* Gracefully exit when telemetry service fails to start

Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andynog andynog

Labels
A: bug Admin: something isn't working I: telemetry Internal: related to Telemetry & metrics
Projects
None yet
Milestone
05.2021
Development

Successfully merging a pull request may close this issue.

Add host parameter to telemetry config informalsystems/hermes
1 participant
@andynog