-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hermes
is not compatible with ethermint
#1267
Comments
Hello! We at Injective are running our own chain that is Ethermint-based, so we needed all these patches to support Hermes:
Those changes allow to have support for Ethermint chains, while being compatible with gaia and others. I've also rewrote E2E to use our own node and my fork: I have no time to properly organize my work, so feel free to iterate on it for this Issue. ✌️ |
) - collected changes from informalsystems#1267 (comment) - EthAccount definition was directly pasted into the proto library (as different chains the same proto definition, but under a different package path) - added a new configuration option that allows specifying the address derivation as well as the proto type of public keys (e.g. "/injective.crypto.v1beta1.ethsecp256k1.PubKey" or "/ethermint.crypto.v1alpha1.ethsecp256k1.PubKey")
) - collected changes from informalsystems#1267 (comment) - EthAccount definition was directly pasted into the proto library (as different chains the same proto definition, but under a different package path) - added a new configuration option that allows specifying the address derivation as well as the proto type of public keys (e.g. "/injective.crypto.v1beta1.ethsecp256k1.PubKey" or "/ethermint.crypto.v1alpha1.ethsecp256k1.PubKey")
) - collected changes from informalsystems#1267 (comment) - EthAccount definition was directly pasted into the proto library (as different chains the same proto definition, but under a different package path) - added a new configuration option that allows specifying the address derivation as well as the proto type of public keys (e.g. "/injective.crypto.v1beta1.ethsecp256k1.PubKey" or "/ethermint.crypto.v1alpha1.ethsecp256k1.PubKey")
* added Ethermint support (fixes #1267 #1071) - collected changes from #1267 (comment) - EthAccount definition was directly pasted into the proto library (as different chains the same proto definition, but under a different package path) - added a new configuration option that allows specifying the address derivation as well as the proto type of public keys (e.g. "/injective.crypto.v1beta1.ethsecp256k1.PubKey" or "/ethermint.crypto.v1alpha1.ethsecp256k1.PubKey") * added a comment for eth address and change query_account return type back to BaseAccount * check the public key type in ethermint address generation * added a check on `sign_msg` * added comments + reordered example config * added links with information for testing Ethermint * adjusted a comment for `EthAccount` Co-authored-by: Romain Ruetschi <[email protected]>
🎉 🎉 |
* added Ethermint support (fixes informalsystems#1267 informalsystems#1071) - collected changes from informalsystems#1267 (comment) - EthAccount definition was directly pasted into the proto library (as different chains the same proto definition, but under a different package path) - added a new configuration option that allows specifying the address derivation as well as the proto type of public keys (e.g. "/injective.crypto.v1beta1.ethsecp256k1.PubKey" or "/ethermint.crypto.v1alpha1.ethsecp256k1.PubKey") * added a comment for eth address and change query_account return type back to BaseAccount * check the public key type in ethermint address generation * added a check on `sign_msg` * added comments + reordered example config * added links with information for testing Ethermint * adjusted a comment for `EthAccount` Co-authored-by: Romain Ruetschi <[email protected]>
Crate
relayer
Summary
hermes
is not compatible with https://github.com/tharsis/ethermintProblem Definition
Why do we need this feature?
To use
hermes
with chains based onethermint
.What problems may be addressed by introducing this feature?
hermes
will no longer be non-compatible withethermint
Are there any disadvantages of including this feature?
No
Proposal
To be able to use
hermes
withethermint
, we need two things added inhermes
:eth-secp256k1
(Adding key generation algorithm for "eth_secp256k1" #1071)BaseAccount
(here). In case ofethermint
, this account is of typeEthAccount
(proto). This can be done in code by checkingtype_url
value ofprost::Any
type returned byQueryAccountRequest
.For Admin Use
The text was updated successfully, but these errors were encountered: