Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failure due to mismatching bitcoin dependencies in v0.0.6 #525

Closed
5 tasks done
adizere opened this issue Jan 15, 2021 · 3 comments · Fixed by #526
Closed
5 tasks done

Compilation failure due to mismatching bitcoin dependencies in v0.0.6 #525

adizere opened this issue Jan 15, 2021 · 3 comments · Fixed by #526
Labels
A: bug Admin: something isn't working I: dependencies Internal: related to dependencies
Milestone

Comments

@adizere
Copy link
Member

adizere commented Jan 15, 2021

Crate

relayer

Description

version: 239fd6f

We are seeing some github action failures.
The error seems to be with dependencies.
Perhaps originating from the bitcoin crate, but that may be misleading, as even fixing this dependency to = 0.25 the error still appears:

...
   Compiling secp256k1-sys v0.4.0
   Compiling secp256k1 v0.20.0
   Compiling bitcoin v0.26.0
   Compiling relayer v0.0.6 (/Users/adi/Hammers/ibc-rs/relayer)
error[E0277]: the trait bound `DerivationPath: From<StandardHDPath>` is not satisfied
   --> relayer/src/keyring/store.rs:140:61
    |
140 |             .and_then(|k| k.derive_priv(&Secp256k1::new(), &DerivationPath::from(hd_path)))
    |                                                             ^^^^^^^^^^^^^^^^^^^^ the trait `From<StandardHDPath>` is not implemented for `DerivationPath`

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added A: bug Admin: something isn't working I: dependencies Internal: related to dependencies labels Jan 15, 2021
@adizere adizere added this to the v0.1.0 milestone Jan 15, 2021
@adizere adizere mentioned this issue Jan 15, 2021
5 tasks
@ancazamfir
Copy link
Collaborator

I still don't understand why bitcoin v0.26.0 is pulled when =0.25 is specified. And also why we don't see this when running locally.

@ancazamfir
Copy link
Collaborator

Ok, i see it now after cargo upate, thanks Adi!

@adizere
Copy link
Member Author

adizere commented Jan 15, 2021

On master, cargo computes the following dep graph, as far as I can tell:

relayer v0.0.6 (/Users/adi/Hammers/ibc-rs/relayer)
├── anomaly v0.2.0 (*)
├── async-trait v0.1.42 (proc-macro) (*)
├── bech32 v0.7.2
├── bitcoin v0.25.2     <-------
├── hdpath v0.6.0
│   ├── bitcoin v0.26.0 <-------

where the two bitcoin versions differ.
This happens because hdpath specifies

bitcoin = { version = ">= 0.21",

Still, I don't understand why having the two versions of bitcoin (0.25.2 and 0.26) would lead to this issue.

@adizere adizere changed the title Compilation failure in v0.0.6 Compilation failure due to mismatching bitcoin dependencies in v0.0.6 Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working I: dependencies Internal: related to dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants