Raise the WebSocket connection's max_message_size to 256MB
#1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only way to test this is in production with the Osmosis epoch blocks? CC @mircea-c & @greg-szabo I think this may be of interest! |
romac
force-pushed
the
romac/tungstenite-max-size
branch
from
648bec5
to
f328157
Compare
|
Sorry about the delay everyone. I've started running this for the osmosis relayer. Will report back next week. |
|
This branch has been deployed for a few days (ref #1466) with Cephalopod. |
|
Should we drop this PR? It seems like we don't understand the consequence of the changes in this PR, and Thane managed to fix (most of) our WS problems with tendermint/tendermint#7230. |
|
Agreed, let's close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1299
Description
Increase the maximum size of WebSocket messages to 256MB to deal with Osmosis nodes sometimes emitting huge events.
Also increases the max frame size to 64MB to avoid splitting such messages over too many frames.
For contributor use:
unclog.docs/) and code comments.Files changedin the Github PR explorer.