Add a --denom option to the tx raw upgrade-chain command to make the deposit denomination configurable
#1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply changes automatically made by cargo 1.58.0.
Make the denomination string configurable in the chain upgrade proposal issued by the `tx raw upgrade-chain` command.
mzabaluev
added
I: CLI
romac
changed the title
tx raw upgrade-chain--denom option to tx raw upgrade-chain to configure proposal deposit denomination
romac
changed the title
--denom option to tx raw upgrade-chain to configure proposal deposit denomination--denom option to the tx raw upgrade-chain command to make the deposit denomination configurable
romac
reviewed
Jan 19, 2022
.changelog/unreleased/improvements/ibc-relayer-cli/1662-configurable-upgrade-denom.md
Outdated
Show resolved
Hide resolved
romac
reviewed
Jan 19, 2022
romac
requested changes
Jan 19, 2022
Co-authored-by: Romain Ruetschi <[email protected]>
Co-authored-by: Romain Ruetschi <[email protected]>
romac
approved these changes
Jan 19, 2022
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…the deposit denomination configurable (informalsystems#1790) * Normalize Cargo.lock Apply changes automatically made by cargo 1.58.0. * --denom option for hermes tx raw upgrade-chain Make the denomination string configurable in the chain upgrade proposal issued by the `tx raw upgrade-chain` command. * Changelog entries for informalsystems#1790 * Improve the changelog entry for informalsystems#1662 (the relayer-cli part) Co-authored-by: Romain Ruetschi <[email protected]> * Fix typo in the doc for --denom option Co-authored-by: Romain Ruetschi <[email protected]> * Use Option::as_deref Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1662
Description
Add an
--denomoption to thetx raw upgrade-chaincommand to make the deposit denomination configurable.The default is "stake" as was previously hardcoded.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.