-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate support for Gaia v5 in favor of Gaia v7 #2092
Deprecate support for Gaia v5 in favor of Gaia v7 #2092
Conversation
Shouldn't the We should probably also remove the v5 |
This makes sense. Alternatively, with Sean we discussed the following scheme:
Using the scheme "legacy/current" is more appropriate than "current/future" because v7 is already live. We will rarely be ahead of the release cycle (hence no need for "future"). |
Sounds good! |
I ran into an issue when running the
step seems quite brittle. @andynog also ran the script on Fedora and encountered an issue on the same step. @soareschen suggested that perhaps building the new Gaia versions can be made less error-prone by using nix shell in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sean & Mikhail!
* Remove `--legacy` flag from `upgrade-chain` command * Remove options related to `legacy` flag * Remove Proposal::Legacy variant * Update GAIA_BRANCH parameter * Rename docker-compose files and update README accordingly * Update GAIA_BRANCH parameter to v7.0.0 and update README * Have GAIA_BRANCH point to v7.0.1 * Update gaia versions in docker-compose yml files * Debug session w/ Sean * Remove problematic line from gaia.Dockerfile * Commit generated gaia v7 files * Update github workflows and CI README * Remove a bogus argument to docker build * generated new files, push to dockerhub, update reamdes * changelog Co-authored-by: Romain Ruetschi <[email protected]> Co-authored-by: Adi Seredinschi <[email protected]> Co-authored-by: Mikhail Zabaluev <[email protected]>
Closes: #1986
Description
Per the acceptance criteria listed in #1986:
PR author checklist:
unclog
.Added tests: integration (for Hermes) or unit/mock tests (for modules).Updated code comments and documentation (e.g.,docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.