Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract light clients into separate crates #2327

Closed
wants to merge 11 commits into from

Conversation

hu55a1n1
Copy link
Member

Closes: #XXX

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@hu55a1n1 hu55a1n1 changed the title Hu55a1n1/light client crates Extract light clients into separate crates Jun 22, 2022
@hu55a1n1 hu55a1n1 closed this Jul 20, 2022
@adizere
Copy link
Member

adizere commented Aug 3, 2022

For future reference: ADR 011 (PR #2356) describes why we closed un-merged the present PR, briefly:

The present PR attempted to break the circular dependencies [between light client and ibc crate] by extracting all core code (types, traits, etc.) that a light client implementation would possibly need into a separate crate, say ibc-base, and then have both the ibc modules crate and light client implementation crates depend on that ibc-base crate. This was implemented in PR #2327, but the solution seems to be fragile and unmaintainable.

@romac romac deleted the hu55a1n1/light-client-crates branch November 22, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants