Mock testing for ICS 18 (relayer) update client messages #270

adizere · 2020-09-29T21:18:31Z

~~Still need to clean this up, purge duplicate tests (ones in ICS26 "test_update_two_chains"), and extend the documentation.~~

For contributor use:

Unit tests written
Added test to CI if applicable
Updated CHANGELOG_PENDING.md
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Updated relevant documentation (docs/) and code comments
Re-reviewed Files changed in the Github PR explorer

(local part).

ancazamfir

I think it looks good for now. We will evolve this testing infra in the future.

ancazamfir and others added 3 commits September 28, 2020 12:27

merge master

8a492db

Move and adapt the two chain client update test to ics26

53d2147

Added basic ICS18 method + context mock for testing. Should fix for #216

ad86205

(local part).

adizere added the work in progress label Sep 29, 2020

adizere requested review from ancazamfir and romac as code owners September 29, 2020 21:18

change the APIs to look closer to what the realyer will use

11cad7a

ancazamfir assigned adizere and ancazamfir Sep 30, 2020

ancazamfir and others added 4 commits September 30, 2020 10:31

Merge branch 'master' into anca/mvp_mock

bb23f72

move the context update and chain advance in new .recv()

fa0556e

Cleanup for ICS26 and ICS18

31d76b3

Fix for awkward ClientKeeper setters

5489c2b

adizere removed the work in progress label Sep 30, 2020

ancazamfir added 2 commits September 30, 2020 13:24

Merge branch 'master' into anca/mvp_mock

5a749ad

fix the chain mock context tests

1a13313

adizere mentioned this pull request Sep 29, 2022

Follow-up on message processor (handler) implementations cosmos/ibc-rs#115

Closed

12 tasks

ancazamfir approved these changes Sep 30, 2020

View reviewed changes

adizere merged commit 1e5f0b2 into master Sep 30, 2020

adizere deleted the anca/mvp_mock branch September 30, 2020 14:22

Provide feedback