-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tendermint dependencies #280
Conversation
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
=========================================
+ Coverage 13.6% 37.2% +23.5%
=========================================
Files 69 120 +51
Lines 3752 7632 +3880
Branches 1374 2706 +1332
=========================================
+ Hits 513 2843 +2330
- Misses 2618 4369 +1751
+ Partials 621 420 -201
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to keep the git property or should we just use version? Was the git introduced in order to specify the brach? In the past we had
tendermint = "0.15.0"
We will move to 0.17 once it's out, hopefully in a few days. But now we need the fix from informalsystems/tendermint-rs#583 (on top of 0.16.0). Also maybe other commits that will go in master before 0.17 is released. |
Makes sense since there's a dependency on #583 until 0.17 release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
tendermint dependencies need update after merge of #255