Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tendermint dependencies #280

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

ancazamfir
Copy link
Collaborator

Description

tendermint dependencies need update after merge of #255

@ancazamfir ancazamfir requested a review from romac as a code owner October 1, 2020 06:24
@codecov-commenter
Copy link

Codecov Report

Merging #280 into master will increase coverage by 23.5%.
The diff coverage is 61.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #280      +/-   ##
=========================================
+ Coverage    13.6%   37.2%   +23.5%     
=========================================
  Files          69     120      +51     
  Lines        3752    7632    +3880     
  Branches     1374    2706    +1332     
=========================================
+ Hits          513    2843    +2330     
- Misses       2618    4369    +1751     
+ Partials      621     420     -201     
Impacted Files Coverage Δ
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs 0.0% <ø> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/context.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 16.6% <0.0%> (-16.7%) ⬇️
modules/src/ics04_channel/error.rs 75.0% <ø> (+50.0%) ⬆️
modules/src/ics04_channel/packet.rs 0.0% <0.0%> (ø)
modules/src/ics07_tendermint/client_def.rs 0.0% <0.0%> (ø)
modules/src/ics07_tendermint/error.rs 75.0% <ø> (+75.0%) ⬆️
modules/src/ics18_relayer/error.rs 0.0% <0.0%> (ø)
... and 217 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd50d0...a1f6b12. Read the comment docs.

Copy link
Contributor

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to keep the git property or should we just use version? Was the git introduced in order to specify the brach? In the past we had

tendermint = "0.15.0"

@ancazamfir
Copy link
Collaborator Author

Do we really need to keep the git property or should we just use version? Was the git introduced in order to specify the brach? In the past we had

tendermint = "0.15.0"

We will move to 0.17 once it's out, hopefully in a few days. But now we need the fix from informalsystems/tendermint-rs#583 (on top of 0.16.0). Also maybe other commits that will go in master before 0.17 is released.

@andynog
Copy link
Contributor

andynog commented Oct 1, 2020

Makes sense since there's a dependency on #583 until 0.17 release

Copy link
Contributor

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ancazamfir ancazamfir merged commit 9ef22d8 into master Oct 1, 2020
@romac romac deleted the anca/255_fix_dependencies branch October 2, 2020 15:26
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants