Fix bug where Subscribe command would sometimes get dropped in the event monitor
#3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By checking whether the event monitor got a `Shutdown` command after processing an event bactch, the event monitor would drop the `Subscribe` command if one had been received instead in the meantime. By dropping the check, and only shutting down the event monitor after having processed the last received batch, we ensure we do not drop such commands in the future.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3070
Description
By checking whether the event monitor got a
Shutdowncommand after processing an event bactch, the event monitor would drop theSubscribecommand if one had been received instead in the meantime.By dropping the check, and only shutting down the event monitor after having processed the last received batch, we ensure we do not drop such commands in the future.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.