Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for fee granters #3418

Merged
merged 6 commits into from
Jun 16, 2023
Merged

Add integration tests for fee granters #3418

merged 6 commits into from
Jun 16, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jun 14, 2023 •
edited
Loading

Closes: #3416

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from romac June 15, 2023 07:25
@ljoss17 ljoss17 marked this pull request as ready for review June 15, 2023 07:25
@romac romac changed the title Fee Grant integration tests Add integration tests for fee grant Jun 16, 2023
@romac romac changed the title Add integration tests for fee grant Add integration tests for fee granters Jun 16, 2023
@romac romac merged commit 60f0546 into master Jun 16, 2023
34 checks passed
@romac romac deleted the luca_joss/3416-fee-granter-tests branch June 16, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration tests for fee granters
2 participants
@ljoss17 @romac