Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some CI flakiness by ensuring we don't bind the same port twice on chain startup #3422

Merged
merged 4 commits into from
Jun 19, 2023

Conversation

romac
Copy link
Member

@romac romac commented Jun 15, 2023

No description provided.

@romac romac changed the title Ensure we don't allocate the same port twice on chain startup Fix CI flakiness by ensuring we don't allocate the same port twice on chain startup Jun 15, 2023
@romac romac changed the title Fix CI flakiness by ensuring we don't allocate the same port twice on chain startup Fix CI flakiness by ensuring we don't bind the same port twice on chain startup Jun 15, 2023
@romac romac marked this pull request as ready for review June 15, 2023 10:54
@romac romac requested a review from ljoss17 June 15, 2023 10:54
@romac romac changed the title Fix CI flakiness by ensuring we don't bind the same port twice on chain startup Fix some CI flakiness by ensuring we don't bind the same port twice on chain startup Jun 16, 2023
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romac romac merged commit 6959325 into master Jun 19, 2023
34 checks passed
@romac romac deleted the romac/random-unused-port branch June 19, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants