Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic support for ICS09 localhost clients #3611

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Basic support for ICS09 localhost clients #3611

wants to merge 9 commits into from

Conversation

romac
Copy link
Member

@romac romac commented Sep 13, 2023 •
edited
Loading

See: #3435

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

romac
romac commented Sep 13, 2023
View reviewed changes
crates/relayer-types/src/clients/ics09_localhost/v2/client_state.rs Outdated Show resolved Hide resolved
crates/relayer-types/src/clients/ics09_localhost/v2/client_state.rs

impl Ics02ClientState for ClientState {
fn chain_id(&self) -> ChainId {
unimplemented!()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME: Properly handle lack of chain id for localhost v2 client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@romac