Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use abci_query instead of gRPC queries during health-check #4102

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Use abci_query instead of gRPC queries during health-check #4102

merged 4 commits into from
Aug 26, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jul 29, 2024 •
edited
Loading

Closes: #4163

Description

This PR replaces the gRPC queries done during health-check with abci_query.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 marked this pull request as ready for review August 26, 2024 13:51
@ljoss17 ljoss17 added this pull request to the merge queue Aug 26, 2024
Merged via the queue into master with commit 4b97bfa Aug 26, 2024
30 checks passed
@ljoss17 ljoss17 deleted the luca_joss/use-abci-query-for-health-check branch August 26, 2024 15:20
@allthatjazzleo allthatjazzleo mentioned this pull request Aug 26, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use abci_query instead of gRPC queries during health-check
2 participants
@ljoss17 @romac