Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gRPC query ConnectionParams instead of /genesis to verify max_block_time #4144

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Use gRPC query ConnectionParams instead of /genesis to verify max_block_time #4144

merged 5 commits into from
Aug 14, 2024

Commits on Aug 13, 2024

  1. Use gRPC query to retrieve 'max_block_time' instead of querying the e… 

    …ntire genesis data
    @ljoss17
    ljoss17 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    6960310 View commit details
    Browse the repository at this point in the history

  2. Add changelog entry

    @ljoss17
    ljoss17 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    07a6f40 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Romain Ruetschi <[email protected]>
Co-authored-by: Anca Zamfir <[email protected]>
Signed-off-by: Luca Joss <[email protected]>
    @ljoss17 @romac @ancazamfir
    3 people authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    79728af View commit details
    Browse the repository at this point in the history

  2. Override configured if it differs from queried value

    @ljoss17
    ljoss17 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ae81050 View commit details
    Browse the repository at this point in the history

  3. Add debug log with queried value for 'max_expected_time_per_block'

    @ljoss17
    ljoss17 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7d736c0 View commit details
    Browse the repository at this point in the history