Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize specs repo #439

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Reorganize specs repo #439

merged 1 commit into from
Dec 3, 2020

Conversation

milosevic
Copy link
Contributor

@milosevic milosevic commented Dec 3, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #439 (18c69df) into master (b1b37f5) will increase coverage by 23.0%.
The diff coverage is 68.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #439      +/-   ##
=========================================
+ Coverage    13.6%   36.7%   +23.0%     
=========================================
  Files          69     154      +85     
  Lines        3752   11088    +7336     
  Branches     1374    4259    +2885     
=========================================
+ Hits          513    4072    +3559     
- Misses       2618    6403    +3785     
+ Partials      621     613       -8     
Impacted Files Coverage Δ
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs 0.0% <ø> (ø)
modules/src/ics02_client/msgs.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 13.6% <0.0%> (-19.7%) ⬇️
modules/src/ics04_channel/error.rs 75.0% <ø> (+50.0%) ⬆️
modules/src/ics04_channel/msgs/chan_close_init.rs 56.8% <ø> (ø)
modules/src/ics04_channel/msgs/chan_open_ack.rs 64.2% <ø> (ø)
...odules/src/ics04_channel/msgs/chan_open_confirm.rs 61.9% <ø> (ø)
modules/src/ics04_channel/msgs/chan_open_init.rs 67.0% <ø> (ø)
... and 285 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be001eb...18c69df. Read the comment docs.

@istoilkovska istoilkovska self-requested a review December 3, 2020 15:40
Copy link
Contributor

@istoilkovska istoilkovska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@milosevic milosevic merged commit 15bac8c into master Dec 3, 2020
@romac romac deleted the zm-reorg branch April 8, 2021 20:41
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants