Use a stateless light client #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
9 tasks
…s for each request
5 tasks
ancazamfir
approved these changes
Apr 1, 2021
ancazamfir
reviewed
Apr 1, 2021
| operations, | ||
| state::State as LightClientState, | ||
| store::{memory::MemoryStore, LightStore}, | ||
| types::Height as TMHeight, |
There was a problem hiding this comment.
nit: why don't we get a clippy on TMHeight?
There was a problem hiding this comment.
Because it's a type alias (I think), will fix it in #793.
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Use stateless light client API * Use peer id and timeout for light client config * Update changelog * Add LightClient::fetch method * Remove LightClient::verify_to_latest * Simply mock light client types * Allow specifying a client state to derive light client security params for each request * Fix mock light client * Fix import name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #673
Description
This PR introduces a stateless light client implementation, where we do not use a persistent store to hold the latest trusted block but rather supply the trusted block height at each use site.
The light client security parameters are now derived from the client state supplied to the light client at each request.
Moreover, this PR makes use of the light client instance directly instead of spawning a supervisor runtime. The latter is indeed redundant since misbehavior monitoring and evidence submission are now the direct responsibility of the relayer (cf. #632).
For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.