Made other mod's public and removed missing_docs lint rule for now #6
Conversation
Cargo.lock
Outdated
| @@ -88,7 +88,7 @@ dependencies = [ | |||
|
|
|||
There was a problem hiding this comment.
Should the .lock file be tracked in the repo?
There was a problem hiding this comment.
It is recommended for projects which include a binary to track their Cargo.lock in version control: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries
There was a problem hiding this comment.
Though in this instance, since the main use case for this project is the library, we can actually omit it.
| #[prost(uint64, tag="6")] | ||
| pub proof_height: u64, | ||
| #[prost(message, optional, tag="6")] | ||
| pub proof_height: ::std::option::Option<super::client::Height>, |
There was a problem hiding this comment.
The Height as defined here is a tuple of two u64, so it's important to note that this will likely impact our code (e.g., the TryFromRaw) and other parts.
There was a problem hiding this comment.
| let x = MsgCreateClient { signer: vec![] }; | ||
| assert_eq!(x.signer, vec![]); | ||
| } | ||
| // Commenting this out. Until proto files are stable does not make sense to add unit tests |
There was a problem hiding this comment.
I wonder if we should keep updating the generated .rs files if the source .proto files are unstable.
There was a problem hiding this comment.
I think we should pin against a specific version of the Cosmos SDK: https://github.com/informalsystems/ibc-proto/issues/10
Yes, I have started working on these changes. They are quite extensive but not much we can do, the sooner the better to understand them, make the changes and raise any concerns. |
Just some small modifications. Make other modes public other than just IBC. Also remove missing_docs lints for now until there's documentation and proto files are somewhat stable.