You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this still relevant? Looking through the codebase now, I don't see any instances where we're disabling the fallible_impl_from lint, and I think there's one From impl that calls unwrap() internally (converting a u64 to an i64) and there's a TODO above it to fix it.
Currently there are a handful of cases where the
From
trait is implemented and the implementation can panic. This is usually addressed with a conversion to aTryFrom
implementation. See 71f0cd3 and https://rust-lang.github.io/rust-clippy/master/index.html#fallible_impl_fromThe text was updated successfully, but these errors were encountered: