Allow fallible from impls for now and leave todos

tendermint/src/amino_types/ed25519.rs

@@ -30,6 +30,8 @@ impl From<PubKeyResponse> for PublicKey {
     }
 }
 
+// TODO(xla): Either complete implementation or convert to TryFrom.
+#[allow(clippy::fallible_impl_from)]
 impl From<PublicKey> for PubKeyResponse {
     fn from(public_key: PublicKey) -> Self {
         match public_key {

tendermint/src/amino_types/time.rs

@@ -24,6 +24,8 @@ impl ParseTimestamp for Msg {
     }
 }
 
+// TODO(xla): Convert to TryFrom.
+#[allow(clippy::fallible_impl_from)]
 impl From<Time> for Msg {
     fn from(ts: Time) -> Self {
         // TODO: non-panicking method for getting this?

tendermint/src/chain/id.rs

@@ -55,6 +55,8 @@ impl Display for Id {
     }
 }
 
+// TODO(xla): Convert to TryFrom.
+#[allow(clippy::fallible_impl_from)]
 impl<'a> From<&'a str> for Id {
     fn from(s: &str) -> Self {
         Self::from_str(s).unwrap()

tendermint/src/lib.rs

@@ -21,7 +21,7 @@
 )]
 #![allow(clippy::result_unwrap_used)]
 #![allow(clippy::implicit_return, clippy::multiple_crate_versions)]
-#![deny(clippy::cast_possible_truncation)]
+#![deny(clippy::fallible_impl_from)]
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/tendermint/kms/master/img/tendermint.png",
     html_root_url = "https://docs.rs/tendermint/0.11.0"

tendermint/src/private_key.rs

@@ -63,6 +63,8 @@ impl Ed25519Keypair {
     }
 }
 
+// TODO(xla): Conver to TryFrom.
+#[allow(clippy::fallible_impl_from)]
 impl<'a> From<&'a Ed25519Keypair> for ed25519::Seed {
     fn from(keypair: &'a Ed25519Keypair) -> Self {
         Self::from_keypair(&keypair.0[..]).unwrap()

tendermint/src/time.rs

@@ -83,6 +83,8 @@ impl From<SystemTime> for Time {
     }
 }
 
+// TODO(xla): Convert to TryFrom.
+#[allow(clippy::fallible_impl_from)]
 impl From<Time> for SystemTime {
     fn from(t: Time) -> Self {
         t.to_system_time().unwrap()