-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rpc] crate follow-ups #339
Comments
It seems keeping the endpoint data types inside tendermint crate, can also help keeping the serializers private. |
@yihuang from your point of view and keeping the serializer helper methods aside, are their other good reasons to keep the rpc endpoints (or the whole module) inside the tendermint crate? |
I don't have other reasons for that, I think feature guarding is good too ;D |
Given all the recent serialization work, can we close this @thanethomson @greg-szabo ? |
As leftovers from #338 we need to address to main points
net2
dependency out of tendermint crate #338 (comment)net2
dependency out of tendermint crate #338 (comment)The text was updated successfully, but these errors were encountered: