Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path separators in proto-compiler #755

Closed
greg-szabo opened this issue Dec 20, 2020 · 0 comments · Fixed by #754
Closed

Fix path separators in proto-compiler #755

greg-szabo opened this issue Dec 20, 2020 · 0 comments · Fixed by #754

Comments

@greg-szabo
Copy link
Member

There are some relative paths at the beginning of the main function in proto-compiler. To make the application cross-compatible on all platforms, the strings should be converted into PathBuf and instead of hard-coding / as the directory separator, the PathBuf::join method should be used to join the different directories together.

Low priority.

Requires #754 to be merged.
Enhances #723 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant