Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved proto-compiler under tools and fixed main.rs paths #754

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented Dec 19, 2020

Closes #755 .
Part of #723 .

  • Moved the proto-compiler folder.

  • In main.rs, relative paths were updated to accommodate the new path.

  • In main.rs OS-specific folder separators were accommodated. (instead of /, we're using PathBuf::join)

  • Referenced an issue explaining the need for the change

  • Updated all relevant documentation in docs

  • Updated all code comments where relevant

  • Wrote tests

  • Updated CHANGELOG.md

@codecov-io
Copy link

codecov-io commented Dec 19, 2020

Codecov Report

Merging #754 (a9e313e) into master (8bbb09b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #754   +/-   ##
======================================
  Coverage    43.1%   43.1%           
======================================
  Files         204     204           
  Lines       13620   13620           
  Branches     3571    3571           
======================================
  Hits         5874    5874           
  Misses       7369    7369           
  Partials      377     377           
Impacted Files Coverage Δ
tools/proto-compiler/src/constants.rs 0.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bbb09b...a9e313e. Read the comment docs.

@thanethomson thanethomson merged commit 4000253 into master Jan 11, 2021
@thanethomson thanethomson deleted the greg/proto-compiler-replace-under-tools branch January 11, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix path separators in proto-compiler
3 participants