Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light-client: Fix verification of blocks between two trusted heights #1247

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

kostko
Copy link
Contributor

@kostko kostko commented Dec 6, 2022

Fixes #1246

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@kostko kostko force-pushed the kostko/feature/highest-before branch from ddf1aba to f006e5e Compare December 6, 2022 17:54
@kostko kostko force-pushed the kostko/feature/highest-before branch 3 times, most recently from db0bb33 to df10c7c Compare January 4, 2023 13:07
@kostko kostko force-pushed the kostko/feature/highest-before branch from df10c7c to 1440aaa Compare January 4, 2023 13:11
@kostko kostko marked this pull request as ready for review January 4, 2023 13:12
@codecov-commenter
Copy link

Codecov Report

Merging #1247 (1440aaa) into main (d28b935) will increase coverage by 0.2%.
The diff coverage is 99.1%.

@@           Coverage Diff           @@
##            main   #1247     +/-   ##
=======================================
+ Coverage   64.4%   64.7%   +0.2%     
=======================================
  Files        245     245             
  Lines      21582   21687    +105     
=======================================
+ Hits       13916   14045    +129     
+ Misses      7666    7642     -24     
Impacted Files Coverage Δ
light-client/src/tests.rs 93.5% <ø> (ø)
light-client/src/store/sled/utils.rs 76.0% <94.1%> (+4.0%) ⬆️
light-client/src/components/scheduler.rs 77.7% <100.0%> (ø)
light-client/src/light_client.rs 75.0% <100.0%> (+0.2%) ⬆️
light-client/src/store.rs 97.6% <100.0%> (+21.1%) ⬆️
light-client/src/store/memory.rs 81.5% <100.0%> (+14.8%) ⬆️
light-client/src/store/sled.rs 80.3% <100.0%> (+4.2%) ⬆️
light-client/src/supervisor.rs 89.4% <100.0%> (+0.9%) ⬆️
tendermint/src/node.rs 63.9% <0.0%> (+0.1%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

light-client: Verification fails for target height between two trusted heights
3 participants