Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signatory requirement to v0.19 #227

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Update signatory requirement to v0.19 #227

merged 1 commit into from
Apr 20, 2020

Conversation

tony-iqlusion
Copy link
Collaborator

This release of signatory uses the v1.0 releases of the ed25519 and signature crates. Release announcement for those here:

https://www.reddit.com/r/rust/comments/g4w8by/ann_rustcrypto_signature_v10_and_ed25519_v10/

It also eliminates the needless dependencies on the p256 and p384 crates, which tendermint-rs doesn't use (it only uses the k256 crate for the secp256k1 curve definition).

This release uses the v1.0 releases of the `ed25519` and `signature`
crates. Release announcement here:

https://www.reddit.com/r/rust/comments/g4w8by/ann_rustcrypto_signature_v10_and_ed25519_v10/

It also eliminates the needless dependencies on the `p256` and `p384`
crates, which `tendermint-rs` doesn't use (it only uses the `k256` crate
for the secp256k1 curve definition).
@tarcieri tarcieri requested a review from liamsi April 20, 2020 17:42
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -7,7 +7,7 @@ edition = "2018"
[dependencies]
gumdrop = "0.7"
serde = { version = "1", features = ["serde_derive"] }
tendermint = { version = "0.12.0-rc0", path = "../tendermint" }
tendermint = { version = "0.13.0-dev", path = "../tendermint" }
Copy link
Member

@liamsi liamsi Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This supersedes #226

signatory-secp256k1 = "0.18"
signatory = { version = "0.19", features = ["ed25519", "ecdsa"] }
signatory-dalek = "0.19"
signatory-secp256k1 = "0.19"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liamsi liamsi merged commit 46385ad into master Apr 20, 2020
@liamsi liamsi deleted the signatory/v0.19 branch April 20, 2020 18:50
@liamsi liamsi mentioned this pull request Apr 20, 2020
5 tasks
@tony-iqlusion tony-iqlusion mentioned this pull request Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants