Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broke up serializers.rs into its own folder #272

Merged
merged 1 commit into from
May 15, 2020

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented May 14, 2020

This is the next step in refactoring serializers (#247 ). It breaks up the serializers.rs file into its own directory. No other changes were done. (The use clauses were updated accordingly in the new files.)

The "custom" serializers are the ones we'd like to get rid of. In the next step, when CommitSig is introduced, some of these can already go away.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@greg-szabo greg-szabo requested a review from liamsi May 14, 2020 15:51
@codecov-io
Copy link

Codecov Report

Merging #272 into master will decrease coverage by 0.0%.
The diff coverage is 20.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #272     +/-   ##
========================================
- Coverage    27.4%   27.4%   -0.1%     
========================================
  Files          99     101      +2     
  Lines        3694    3696      +2     
  Branches     1169    1169             
========================================
  Hits         1014    1014             
- Misses       1870    1872      +2     
  Partials      810     810             
Impacted Files Coverage Δ
tendermint/src/serializers/custom.rs 13.0% <13.6%> (ø)
tendermint/src/serializers/from_str.rs 22.2% <28.5%> (ø)
tendermint/src/serializers/bytes.rs 31.5% <31.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f3118...2ad32b6. Read the comment docs.

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liamsi liamsi merged commit fcd4e99 into master May 15, 2020
@liamsi liamsi deleted the greg/serialization-3-alter branch May 15, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants