-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quickfix: make fields in event subscription accessible publicly #312
Conversation
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
======================================
Coverage 30.5% 30.5%
======================================
Files 127 127
Lines 4580 4580
Branches 1416 1416
======================================
Hits 1398 1398
Misses 2215 2215
Partials 967 967
Continue to review full report at Codecov.
|
@@ -101,7 +101,8 @@ impl EventListener { | |||
dbg!(&msg.to_string()); | |||
return Ok(None); | |||
} | |||
|
|||
dbg!("received neither event nor generic string message:"); | |||
dbg!(&msg.to_string()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this with IBC relayer and it's "" for #311
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is a ping message:
https://github.com/tendermint/tendermint/blob/ba3a2dde376f708085726cd778bb361bd8c7c692/rpc/jsonrpc/server/ws_handler.go#L407
If the server doesn't drop your event subscription, you can ignore it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the server doesn't drop your event subscription, you can ignore it for now.
Yes, I am ignoring but was wondering if this could be handled more gracefully :) Anyway..this is for the other issue. Just saw you added this here and wanted to mention that for the failure I see it is empty string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am ignoring but was wondering if this could be handled more gracefully :)
Absolutely, the client should actually play ping-pong with the server instead of treating this as an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Non-elegant quickfix: makes all event subscription fields
pub
s.t. they can be accessed and processed.close #308