-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance test fixes #366
Conversation
I think when you had them ready and generated the JSON files, we added them to this repo without the rust code being ready? tendermint-rs/tendermint/tests/lite.rs Lines 193 to 196 in 27298f0
|
Possible, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 I think it would be good if the missing multipeer tests were captured in an issue (if not already the case)
Thanks @liamsi ! Will do that :) |
closes #290
partially addresses: #320 (bisection)
UPDATE: moved
single_peer/invalid_validator_set
tomulti_peer/malicious_validator_set
because it seemed more appropriate.QUESTION: Why do we don't run the
multi_peer/...
tests yet?