Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #399

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Update README.md #399

merged 1 commit into from
Jun 30, 2020

Conversation

konnov
Copy link
Contributor

@konnov konnov commented Jun 30, 2020

Details on the MC-files and the experiments

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@konnov
Update README.md
3f75eda 
Details on the MC-files and the experiments
josef-widder
josef-widder approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@josef-widder josef-widder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Looks great!

@brapse brapse merged commit 4118ef1 into master Jun 30, 2020
@brapse brapse deleted the konnov-patch-1 branch June 30, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josef-widder josef-widder josef-widder approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konnov @josef-widder @brapse