Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: ADR for client event subscription mechanism #476

Merged
merged 19 commits into from
Aug 28, 2020
Merged

rpc: ADR for client event subscription mechanism #476

merged 19 commits into from
Aug 28, 2020

Commits on Jul 23, 2020

  1. Add first draft of ADR-008 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    e2e3581 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. Add comment about WebSockets connection 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    844af0c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Rename to "RPC Client" for greater clarity 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    16eb48f View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. Update docs/architecture/adr-008-event-subscription.md 

    Co-authored-by: Alexander Simmerl <[email protected]>
    @thanethomson @xla
    thanethomson and xla authored Aug 4, 2020
    Configuration menu
    Copy the full SHA
    5101c03 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Update to reflect work on #516 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    e0dcae9 View commit details
    Browse the repository at this point in the history

  2. Leave out implementation details (ADR) 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    12f008f View commit details
    Browse the repository at this point in the history

  3. Clarify handle/driver concurrency model 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f47d461 View commit details
    Browse the repository at this point in the history

  4. Update with latest architecture inspired by #516 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    42e7fad View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Condense Client trait example for readability 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    1884297 View commit details
    Browse the repository at this point in the history

  2. Reduce complexity of subscription interface 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    80be41c View commit details
    Browse the repository at this point in the history

  3. Introduce ClosableClient trait 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    4faedc6 View commit details
    Browse the repository at this point in the history

  4. Reduce number of client implementations 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    18c7f84 View commit details
    Browse the repository at this point in the history

  5. Remove SubscriptionRouter from ADR discussion (it is an implementatio… 

    …n detail)

Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    c465ce8 View commit details
    Browse the repository at this point in the history

  6. Update ERD to reflect current architecture 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    0979380 View commit details
    Browse the repository at this point in the history

  7. Add note on bounded vs unbounded channels in subscriptions 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    7008c07 View commit details
    Browse the repository at this point in the history

  8. Fix link for async drop discussion 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    3304736 View commit details
    Browse the repository at this point in the history

  9. Add more structure and explanation to the Subscription section 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    b598a1a View commit details
    Browse the repository at this point in the history

  10. Add Subscription section on leveraging futures::stream utils 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    0b07458 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Clarify ERD by using colours instead of line thickness 

    Signed-off-by: Thane Thomson <[email protected]>
    @thanethomson
    thanethomson committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    d4ba7aa View commit details
    Browse the repository at this point in the history