Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model-based test driver for LightClient #550

Merged
merged 15 commits into from
Sep 11, 2020
Merged

Model-based test driver for LightClient #550

merged 15 commits into from
Sep 11, 2020

Conversation

andrey-kuprianov
Copy link
Contributor

Part 5 of #529. See also #414. This PR adds model-based test driver to LightClient.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@andrey-kuprianov andrey-kuprianov added enhancement New feature or request light-client Issues/features which involve the light client verification tests labels Sep 2, 2020
@andrey-kuprianov andrey-kuprianov self-assigned this Sep 2, 2020
@andrey-kuprianov
Copy link
Contributor Author

Please review this one after #547 and #549 are merged -- there are dependencies.

romac
romac approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff! Great docs and README as well 👍

@romac romac merged commit e0bbca0 into master Sep 11, 2020
@romac romac deleted the andrey/mbt-lightclient branch September 11, 2020 12:44
@andrey-kuprianov andrey-kuprianov linked an issue Sep 11, 2020 that may be closed by this pull request
Develop a set of model-based tests for the LightClient #414
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@brapse brapse Awaiting requested review from brapse

@xla xla Awaiting requested review from xla

@liamsi liamsi Awaiting requested review from liamsi

@shonfeder shonfeder Awaiting requested review from shonfeder

@Shivani912 Shivani912 Awaiting requested review from Shivani912

Assignees

@andrey-kuprianov andrey-kuprianov

Labels
enhancement New feature or request light-client Issues/features which involve the light client tests verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop a set of model-based tests for the LightClient
2 participants
@andrey-kuprianov @romac