rpc: Rename WebSocketSubscriptionClient #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent future API breakage when we implement `Client` for the WebSocket-based client (i.e. all the non-subscription-related RPC calls), I'd recommend we rename `WebSocketSubscriptionClient` to just `WebSocketClient`. Then developers can simply import whichever trait they'd like implemented for the client to get the relevant functionality. Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
thanethomson
changed the title
ebuchman
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on PR from #516.
To prevent future API breakage when we implement
Clientfor the WebSocket-based client (i.e. all the non-subscription-related RPC calls), I'd recommend we renameWebSocketSubscriptionClientto justWebSocketClient.Then developers can simply import whichever trait they'd like implemented for the client to get the relevant functionality.