Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Add testing-related documentation overview #604

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Conversation

thanethomson
Copy link
Contributor

@thanethomson thanethomson commented Oct 1, 2020

Closes #597

Rendered README

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@codecov-commenter
Copy link

Codecov Report

Merging #604 into master will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #604   +/-   ##
======================================
  Coverage    41.3%   41.3%           
======================================
  Files         163     163           
  Lines       11317   11311    -6     
  Branches     2558    2559    +1     
======================================
  Hits         4682    4682           
+ Misses       6264    6258    -6     
  Partials      371     371           
Impacted Files Coverage Δ
tendermint/src/time.rs 59.1% <0.0%> (+6.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c13625...f71b6af. Read the comment docs.

melekes
melekes previously approved these changes Oct 5, 2020
Copy link
Member

@ebuchman ebuchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super helpful, especially for surfacing more questions, thanks!

rpc/README.md Show resolved Hide resolved
rpc/README.md Show resolved Hide resolved
@ebuchman ebuchman merged commit b2d1555 into master Oct 8, 2020
@ebuchman ebuchman deleted the docs/rpc-testing branch October 8, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Document testing of rpc crate
4 participants