Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_commitish now accepts commit IDs #662

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Conversation

greg-szabo
Copy link
Member

Closes #660

  • Introduces a find_reference_or_commit() function to deal with tags, branches and commits together.

  • Cleans up some of the function names and tries to make the code more readable.

  • Referenced an issue explaining the need for the change

  • Updated all relevant documentation in docs

  • Updated all code comments where relevant

  • Wrote tests

  • Updated CHANGELOG.md

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thanethomson thanethomson merged commit 0b1962a into master Nov 9, 2020
@thanethomson thanethomson deleted the greg/git_commit_id branch November 9, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make protobuf generation accept commits
3 participants