Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build optimizations #725

Merged
merged 1 commit into from
Dec 10, 2020
Merged

build optimizations #725

merged 1 commit into from
Dec 10, 2020

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented Dec 8, 2020

Small step toward #723 .

Introduces a few new cargo commands so that developers and the CI can easily run the same commands.

  • cargo build-all == cargo build --workspace --all-targets
  • cargo build-wasm-tendermint == (build tendermint with the wasm32-unknown-unknown target)
  • cargo build-wasm-light-client == (build tendermint-light-client with the wasm32-unknown-unknown target)

This is a small example of how building and testing can be simplified between the developer and the CI. Further cases will come as I research the tools mentioned in #723.

Edit: it would be nice to have a simple cargo build-wasm command, but currently it's not possible, because the --no-default-features parameter cannot run in a virtual workspace, hence we need to add the --manifest-path parameter to point to the specific package's Cargo.toml as well as the --package parameter (describing the crate name) to point to the package that should be built.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@codecov-io
Copy link

Codecov Report

Merging #725 (ff2ebc8) into master (1892b69) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #725   +/-   ##
======================================
  Coverage    42.5%   42.5%           
======================================
  Files         202     202           
  Lines       12904   12904           
  Branches     3298    3298           
======================================
  Hits         5496    5496           
  Misses       7058    7058           
  Partials      350     350           
Impacted Files Coverage Δ
light-client/src/macros.rs 11.1% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1892b69...ff2ebc8. Read the comment docs.

@thanethomson thanethomson merged commit d3d16be into master Dec 10, 2020
@thanethomson thanethomson deleted the greg/ci-optimalization branch December 10, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants