Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jsonrpc to upgrade hyper #804

Merged
merged 5 commits into from
Feb 9, 2021
Merged

Conversation

thanethomson
Copy link
Contributor

@thanethomson thanethomson commented Feb 8, 2021

Closes #803

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
@thanethomson thanethomson marked this pull request as ready for review February 8, 2021 18:35
@@ -1,6 +0,0 @@
//! Core logic and traits of a light client.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file isn't used by any modules in the tendermint crate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

xla
xla previously approved these changes Feb 9, 2021
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚥 🗽 🌌 ⛴

romac
romac previously approved these changes Feb 9, 2021
@romac romac dismissed stale reviews from xla and themself via a034cc1 February 9, 2021 11:16
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌗 🎞 😀 🎎

@romac romac merged commit 1a66290 into master Feb 9, 2021
@romac romac deleted the thane/803-ln-hyper-upgrade branch February 9, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo audit shows vulnerability in tendermint-light-node (hyper v0.12.35)
3 participants