OH2-257 | Revise HTTP response codes in API #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbmalkovsky
reviewed
Feb 16, 2024
| @@ -123,13 +123,13 @@ public ResponseEntity<FullBillDTO> newBill(@RequestBody FullBillDTO newBillDto) | |||
| if (pat != null) { | |||
| bill.setBillPatient(pat); | |||
| } else { | |||
| throw new OHAPIException(new OHExceptionMessage("Patient not found.")); | |||
| return ResponseEntity.badRequest().body(new OHExceptionMessage("Patient not found.")); | |||
There was a problem hiding this comment.
I find three different return values for something not found:
return ResponseEntity.badRequest().body("XXXX not found.");
return ResponseEntity.badRequest().body(new OHExceptionMessage("XXXX not found."));
return ResponseEntity.notFound().build();
Shouldn't there only be one form?
dbmalkovsky
reviewed
Feb 16, 2024
| if (!admtManager.isCodePresent(code)) { | ||
| throw new OHAPIException(new OHExceptionMessage("Admission Type is not created."), HttpStatus.INTERNAL_SERVER_ERROR); | ||
| if (admtManager.isCodePresent(code)) { | ||
| return ResponseEntity.badRequest().body(new OHExceptionMessage("The code of Admission Type is already used.")); |
There was a problem hiding this comment.
There appears to be two different returns for something already present/being used:
return ResponseEntity.badRequest().body(new OHExceptionMessage("XXXXX is already used."));
return ResponseEntity.internalServerError().body(new OHExceptionMessage("XXXXX is already present."));
Shouldn't there only be one?
added 2 commits
February 16, 2024 15:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OH2-257.