Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you specify a UnixSocket, your HostName is ignored #188

Open
bmillwood opened this issue Sep 15, 2022 · 1 comment
Open

If you specify a UnixSocket, your HostName is ignored #188

bmillwood opened this issue Sep 15, 2022 · 1 comment
Assignees

Comments

@bmillwood
Copy link
Contributor

I think instead of connectHost and connectPort, the connection details should include connectAddr which is a SockAddr. This would help avoid confusion about what connectHost does or whether it needs to be set correctly when you're connecting via Unix socket.

bmillwood added a commit to bmillwood/hedis that referenced this issue Sep 15, 2022
bmillwood added a commit to bmillwood/hedis that referenced this issue Sep 15, 2022
@aravindgopall aravindgopall self-assigned this Feb 23, 2023
@aravindgopall
Copy link
Collaborator

Merging #189.

We can further discuss here about how to take this forward with maintaining backward compatibility for the current users. Another idea is to make the connectHost as Maybe and return error on Nothing when connectPort is not Unix Socket.

qnikst pushed a commit to SiriusCourses/hedis that referenced this issue May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants