Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletes Select queries, updates docker images, docs and tests #89

Merged
merged 2 commits into from
May 2, 2020

Conversation

anskarl
Copy link
Contributor

@anskarl anskarl commented May 1, 2020

Delete Select queries. Since Druid 0.17.0, it has been removed and replaced by the Scan query

Update docker images:

  • Druid 0.18.0
  • Zookeeper 3.5.7

Update documentation and unit tests

…eplaced by the Scan query

Updates docker images
  - Druid 0.18.0
  - Zookeeper 3.5.7

Updates documentation and unit tests
@anskarl anskarl changed the title Delete Select queries and update docker images, docs and tests Deletes Select queries, updates docker images, docs and tests May 1, 2020
@barend
Copy link
Contributor

barend commented May 1, 2020

Thank you for this PR! The docker images all build, the tests all run, and it's a nice cleanup. This is all in order and ready to go.

@krisgeus this is ready to merge.

@anskarl as far as I am concerned, you're more than welcome to add yourself to developers in ThisBuild if you want.

@anskarl
Copy link
Contributor Author

anskarl commented May 2, 2020

@barend thank you for reviewing the PR. I would be grateful to be included in the list of developers, I will add one more commit for this change.

@krisgeus krisgeus merged commit 6ca225b into ing-bank:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants