detect which cloud provider we are using #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here we see the debug |
devsecfranklin
changed the title
JayBeale
reviewed
May 9, 2023
|
devsecfranklin
commented
May 11, 2023
peirates.go
Outdated
| @@ -13,6 +13,7 @@ import ( | |||
| "os/exec" | |||
| "regexp" | |||
| "strings" | |||
| L "./lib" | |||
There was a problem hiding this comment.
It seems angry about this location. Will consult the style guide.
/home/franklin/go/bin/golangci-lint run
peirates.go:6:2: local import "./lib" in non-local package (typecheck)
L "./lib"
^
make: *** [Makefile:11: lint] Error 1
~/w/d/peirates (dev37-20230508±) ▶
I think the formatting of the result will be similar, agreed. But the difference is in the way we detect each different provider. I guess help me understand where in the code we would implement this? |
|
With the exception of Openstack, we can detect cloud provider via a single HTTP request. I'm thinking this might be implementable as a table of:
For OpenStack, it's a file read but that doesn't seem to be applicable to our use case. So we can leave that out. The only other file reads are checking to see whether you're in a containerd-spawned container and whether you're in a Kubernetes pod. Both of those really belong in separate code. Here's an example - but it would be better to use DoHTTPRequestAndGetBody() instead of having all this HTTP logic: Function definition for DoHTTPRequestAndGetBody(): // DoHTTPRequestAndGetBody performs an HTTP request, and returns the full
// body of the reponse as a string. If ignoreTLSErrors is true, all TLS
// errors, such as invalid certificates, will be ignored. If caCertPath is
// not an empty string, a TLS certificate will be read from the provided path
// and added to the pool of valid certificates.
func DoHTTPRequestAndGetBody(req *http.Request, https bool, ignoreTLSErrors bool, caCertPath string) ([]byte, error) {Example: type CloudProvider struct {
Name string
URL string
HTTPMethod string
CustomHeader string
CustomHeaderValue string
ResultString string
}
func populateAndCheckCloudProviders() {
providers := []CloudProvider{
{
Name: "Provider1",
URL: "https://example.com/provider1",
HTTPMethod: "GET",
CustomHeader: "X-Custom-Header",
CustomHeaderValue: "Value1",
ResultString: "Provider1 found",
},
{
Name: "Provider2",
URL: "https://example.com/provider2",
HTTPMethod: "POST",
CustomHeader: "",
CustomHeaderValue: "",
ResultString: "Provider2 found",
},
// Add more cloud providers as needed
}
for _, provider := range providers {
fmt.Printf("Checking %s...\n", provider.Name)
// Use DoHTTPRequestAndGetBody()
req, err := http.NewRequest(provider.HTTPMethod, provider.URL, nil)
if err != nil {
fmt.Printf("Failed to create request for %s: %v\n", provider.Name, err)
continue
}
if provider.CustomHeader != "" {
req.Header.Set(provider.CustomHeader, provider.CustomHeaderValue)
}
// use DoHTTPRequestAndGetBody
resp, err := client.Do(req)
if err != nil {
fmt.Printf("Failed to make request to %s: %v\n", provider.Name, err)
continue
}
defer resp.Body.Close()
// Use DoHTTPRequestAndGetBody()
if resp.StatusCode == http.StatusOK {
// Check if there's a body string returned that matches ResultString
} else {
fmt.Printf("%s responded with HTTP %d\n", provider.Name, resp.StatusCode)
}
}
} |
JayBeale
requested changes
Jun 30, 2023
| HTTPMethod: "GET", | ||
| CustomHeader: "", | ||
| CustomHeaderValue: "", | ||
| ResultString: "Microsoft Azure", |
There was a problem hiding this comment.
Looks like a copy-paste error on this line that can be easily fixed.
JayBeale
approved these changes
Jul 4, 2023
JayBeale
added a commit
that referenced
this pull request
Jul 4, 2023
JayBeale
added a commit
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to detect the cloud provider in a concise manner.