Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configurable keep alive option #44

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: configurable keep alive option #44

wants to merge 5 commits into from

Conversation

JSHan94
Copy link
Collaborator

@JSHan94 JSHan94 commented Jul 1, 2024 •
edited
Loading

@JSHan94 JSHan94 requested a review from a team as a code owner July 1, 2024 06:50
@Vritra4
Copy link
Contributor

Vritra4 commented Jul 1, 2024

FILL DESCRIPTION PLEASE

@Vritra4
Copy link
Contributor

Vritra4 commented Jul 1, 2024

how about changing the config to DISABLE_HTTP_KEEPALIVE
because KeepAlive haunts operator only utilizing redirected rpcs/lcds

@JSHan94
Copy link
Collaborator Author

JSHan94 commented Jul 1, 2024

how about changing the config to DISABLE_HTTP_KEEPALIVE because KeepAlive haunts operator only utilizing redirected rpcs/lcds

There're some options like ENABLE_ORACLE, ENABLE_API_ONLY so what about keeping name convention.

@Vritra4
Copy link
Contributor

Vritra4 commented Jul 1, 2024

how about changing the config to DISABLE_HTTP_KEEPALIVE because KeepAlive haunts operator only utilizing redirected rpcs/lcds

There're some options like ENABLE_ORACLE, ENABLE_API_ONLY so what about keeping name convention.

They are not relevant for each other, and poor performance by default sounds weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSHan94 @Vritra4