fix(core): use -mfr only for cc2022+
#923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in the PR #656 two years ago, it causes invalid argument
-mfrerror when trying to render with aerender version older than 2022.In #656 @chrisapplegate added new
commandLineRenderer-2022.jsxfor AE 2022+, and keptcommandLineRenderer-default.jsxfor pre-2022, they were patched correctly. But Chris forgot to check the version and applied the cc2022-only argument-mfrin all cases, resulting a regression.It seems this regression has lasted a long time and no one noticed. Recently I tried to upgrade the dependencies of my project which stays at using old version of aerender and found that a
-mfrerror throws when I update@nexrender/coreto any version greater then 1.32.x. #656 was shipped in 1.33.0, all versions of@nexrender/corestarting from 1.33.0 are buggy.