Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/modify inmanta install guide #2869

Closed
wants to merge 21 commits into from

Conversation

Pouriya-Inmanta
Copy link
Contributor

Description

  • Revised Inmanta install guide for Debian

Copy link
Contributor

@wouterdb wouterdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

changelogs/unreleased/modify_Inmanta_install_guide.yml Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved

OR

2. Get the source from `our github page <https://github.com/inmanta/inmanta-dashboard/releases>`_ on the right and under `Assets`, you will see the source. Next, build and install the dashboard. For this you need to have yarn and grunt:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this part, using the pre-built npm is easier

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bart: wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should I go about it? keep it or remove it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the prebuilt version

docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
@bartv bartv requested a review from arnaudsjs April 21, 2021 12:58
@bartv
Copy link
Contributor

bartv commented Apr 21, 2021

I would like arnaud to have a look at this as well, he has cleaned up these instructions before and has a much better eye for this than me

docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
@Pouriya-Inmanta Pouriya-Inmanta removed the request for review from butterybread April 22, 2021 12:13
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/install/install-server/install-server.inc Outdated Show resolved Hide resolved
docs/Makefile Outdated
@@ -56,7 +56,6 @@ clean:
-rm -rf $(PNGs)

html: openapi latexpdf
cp $(BUILDDIR)/latex/inmanta.pdf $(SOURCEDIR)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has to stay, even if I'm not sure why?

@arnaudsjs do you know why this is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It has to stay. A PDF version of the documentation is included in the HTML version of the documentation. This command moves the PDF from the output directory of the PDF build to the source directory of the HTML build.

@bartv
Copy link
Contributor

bartv commented Apr 28, 2021

@Pouriya-Inmanta make sure you use merge-tool and not merge it yourself

@Pouriya-Inmanta Pouriya-Inmanta added the merge-tool-ready This ticket is ready to be merged in label Apr 28, 2021
@inmantaci
Copy link
Contributor

Processing this pull request

inmantaci added a commit that referenced this pull request Apr 28, 2021
# Description

* Revised Inmanta install guide for Debian
@inmantaci
Copy link
Contributor

Failed to merge changes into iso3 due to merge conflict.Please open a pull request for these branches separately.

@inmantaci inmantaci removed the merge-tool-ready This ticket is ready to be merged in label Apr 28, 2021
@inmantaci
Copy link
Contributor

Merged into branches master in da183d1

@inmantaci
Copy link
Contributor

Not closing this pull request due to previously commented issues for some of the destination branches. Please open a separate pull request for those branches. You can safely close this pull request and delete the source branch.

inmantaci added a commit that referenced this pull request Apr 28, 2021
# Description

* Revised Inmanta install guide for Debian
@inmantaci
Copy link
Contributor

Processing #2889.

inmantaci added a commit that referenced this pull request Apr 28, 2021
Pull request opened by the merge tool on behalf of #2869
inmantaci added a commit that referenced this pull request Apr 28, 2021
# Description

This is the second stage merge request for #2869. @sanderr  did I do this correctly and should I close the other one by hand?
@Pouriya-Inmanta
Copy link
Contributor Author

Merged in #2891 after resolving the conflict.

@bartv bartv deleted the issue/modify_Inmanta_install_guide branch July 12, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants