Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sentry middleware setup example for Python #993

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

rbm
Copy link
Contributor

@rbm rbm commented Nov 14, 2024

Inngest expects a list of uninitialized middleware here, i.e. the actual SentryMiddleware class rather than an instance of it.

The class is initialized in MiddlewareManager.add when sending events.

Inngest expects a list of uninitialized middleware here, i.e. the actual SentryMiddleware class rather than an instance of it.

The class is initialized in MiddlewareManager.add when sending events.
Copy link

vercel bot commented Nov 14, 2024

@rbm is attempting to deploy a commit to the Inngest Team on Vercel.

A member of the Team first needs to authorize it.

@rbm
Copy link
Contributor Author

rbm commented Nov 14, 2024

The code in the example currently throws an exception because SentryMiddleware has required parameters (which MiddlewareManager supplies)

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 8:14am

Copy link
Contributor

@charlypoly charlypoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this @rbm! ⚡

@charlypoly charlypoly merged commit 8fea0ac into inngest:main Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants