Tiny fixes in mysql checks #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Woellchen
reviewed
Aug 28, 2023
kofrezo
requested changes
Aug 30, 2023
There was a problem hiding this comment.
You can use the configparser module here instead of building your own code :-)
| @@ -60,6 +60,18 @@ def parse_args(): | |||
|
|
|||
| return parser.parse_args() | |||
|
|
|||
| def check_config_file(conf_fd): | |||
There was a problem hiding this comment.
Suggested change
| def check_config_file(conf_fd): | |
| def check_config_file(conf_fd): | |
| # Import configparser module on top | |
| config = configparser.ConfigParser() | |
| config.read_file(conf_fd) | |
| return config.has_section('mysqld') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/check_mysql_conf.py: Empty files with only [mysqld] line are producing an error in pt-config-diff - checking if there is at least one non-empty line in the config file.