Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug (YouTube): Navigation bar elements is not hiding, when they have new icons #2169

Closed
5 tasks done
GucekPL opened this issue Jun 19, 2024 · 18 comments
Closed
5 tasks done
Labels
A/B test Reproducible only in some users Bug report Something isn't working

Comments

@GucekPL
Copy link

GucekPL commented Jun 19, 2024

Type

Error at runtime

Tools used

RVX Manager

Application

YT app version: 19.25.39

Bug description

Today, YouTube decided to endow my Google account with new navigation bar icons. Along with this, hiding the notification button no longer works.

Steps to reproduce:

  1. Make sure you have the icons as in the screenshot below
    image
  2. Enable Swap Create and Notifications buttons and Hide notifications button in the Navigation buttons options
    image
  3. As shown, notifications button is still showing
    image

Error logs

No response

Solution

Rollback to YouTube 19.16.39

Additional context

No response

Device Environment

No response

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@GucekPL GucekPL added the Bug report Something isn't working label Jun 19, 2024
@GucekPL
Copy link
Author

GucekPL commented Jun 19, 2024

I would also add that I checked the option to hide the notification button in the toolbar, and it doesn't work too

@GucekPL GucekPL changed the title bug (YouTube): Notifications button is not hiding, when the navigation bar has new icons bug (YouTube): Notifications button is not hiding, when the navigation bar has new icons Jun 19, 2024
@inotia00 inotia00 added the A/B test Reproducible only in some users label Jun 19, 2024
@inotia00
Copy link
Owner

It looks like A/B tests
Not only the Notification button, but also other buttons are not hidden? (Home, Shorts, Scubscriptions, etc..)

@GucekPL
Copy link
Author

GucekPL commented Jun 19, 2024

Navigation bar:

  • Home ➞ not hidden
  • Shorts ➞ not hidden
  • Create ➞ not hidden
  • Subscriptions ➞ not hidden
  • Notifications ➞ not hidden
  • You / Library ➞ hidden

Toolbar:

  • Cast ➞ hidden
  • Create ➞ hidden
  • Notifications ➞ not hidden

@inotia00

This comment was marked as outdated.

@GucekPL

This comment was marked as outdated.

@inotia00

This comment was marked as outdated.

@inotia00

This comment was marked as outdated.

@GucekPL

This comment was marked as outdated.

@GucekPL
Copy link
Author

GucekPL commented Jun 22, 2024

@inotia00
image
I have only 2 logs after opening RVX

@GucekPL GucekPL changed the title bug (YouTube): Notifications button is not hiding, when the navigation bar has new icons bug (YouTube): Navigation bar elements is not hiding, when they have new icons Jun 22, 2024
@inotia00
Copy link
Owner

Thanks.. I think the Cairo icon cannot be identified by the Enum value
(requires deeper debugging)

It seems that a fix is ​​only possible when this A/B test is applied to my account

btw Cairo icon for navigation bar was added in YouTube 19.20.35, so using YouTube 19.16.39 may solve the issue

@inotia00
Copy link
Owner

One last thing, please test that the Hide navigation labels setting works

@GucekPL
Copy link
Author

GucekPL commented Jun 22, 2024

Works

@GucekPL
Copy link
Author

GucekPL commented Jul 1, 2024

@inotia00 1 hour ago, Google reverted for my account new Cairo-icons, so all works perfectly again. LMAO 😅

@inotia00
Copy link
Owner

In revanced-patches-4.10.2, the supported version has been rolled back to YouTube 19.16.39.
This bug is only reproducible on YouTube 19.20.xx+, so the issue is closed.

inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Aug 28, 2024
inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Aug 28, 2024
@GucekPL
Copy link
Author

GucekPL commented Aug 28, 2024

@inotia00 so from now, hiding works on new icons?

@inotia00
Copy link
Owner

Yes the patch supports it now, but I haven't been able to test it because the A/B tests were reverted on my account the day after I checked the debug logs

@GucekPL
Copy link
Author

GucekPL commented Aug 28, 2024

Yes the patch supports it now, but I haven't been able to test it because the A/B tests were reverted on my account the day after I checked the debug logs

In my case these icons are appearing and dissappearing randomly 😅

@AbakNacchan
Copy link

Up to which version that doable using this source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A/B test Reproducible only in some users Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants