Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube/Disable force auto captions): patch doesn't work with Shorts #2346

Closed
6 tasks done
federicogith opened this issue Aug 29, 2024 · 5 comments
Closed
6 tasks done
Labels
Bug report Something isn't working

Comments

@federicogith
Copy link

Type

Error while patching

Tools used

RVX Manager

Application

YouTube v19.16.39
Patches latest dev release

Bug description

Explained in the title.

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I didn't use any settings marked as Experimental Flags.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@federicogith federicogith added the Bug report Something isn't working label Aug 29, 2024
@inotia00
Copy link
Owner

Please attach an example of a shorts video with forced auto captions applied

@federicogith
Copy link
Author

federicogith commented Aug 29, 2024

Please attach an example of a shorts video with forced auto captions applied

The bug seems to arise only with Shorts in the subscriptions feed AND with certain system languages, I only tried Italian

@inotia00 inotia00 changed the title bug: "Disable force auto captions" doesn't work with Shorts bug(YouTube/Disable force auto captions): patch doesn't work with Shorts Aug 29, 2024
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Aug 31, 2024
@inotia00
Copy link
Owner

inotia00 commented Aug 31, 2024

There is an issue when applying patches in Shorts: #484

To prevent this, patches are not applied to Shorts

Since this old bug cannot be fixed, the following description will be added to the settings:

Limitation: This setting does not apply to Shorts

@inotia00
Copy link
Owner

inotia00 commented Sep 2, 2024

nvm I refactored the patch so it now works properly in Shorts too

@inotia00
Copy link
Owner

inotia00 commented Sep 7, 2024

reflected in revanced-patches-4.13.1

@inotia00 inotia00 closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants