Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube/Shorts components): Hide Use this sound button doesn't work #2356

Closed
6 tasks done
Kuddus73 opened this issue Sep 1, 2024 · 7 comments
Closed
6 tasks done
Labels
Bug report Something isn't working

Comments

@Kuddus73
Copy link

Kuddus73 commented Sep 1, 2024

Type

Other

Tools used

RVX Manager

Application

YouTube v19.16.39
Patches v4.13.1-dev.2

Bug description

Screen_Recording_20240901_032341_YouTube.mp4

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I didn't use any settings marked as Experimental Flags.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@Kuddus73 Kuddus73 added the Bug report Something isn't working label Sep 1, 2024
@inotia00
Copy link
Owner

inotia00 commented Sep 1, 2024

This setting belongs to the PreferenceScreen Shorts player

That is, this setting hides the Use this sound button in the Shorts player #2349

The video you attached is not a button in the Shorts player

@inotia00 inotia00 closed this as completed Sep 1, 2024
@Kuddus73
Copy link
Author

Kuddus73 commented Sep 1, 2024

That is, this setting hides the Use this sound button in the Shorts player #2349

The video you attached is not a button in the Shorts player

I didn't know that there were two different buttons with the same name.

But still, the button is not hidden:
Screenshot_20240901_051455_YouTube

Perhaps it is another button with the same name again, but this one is a button in the Shorts player.

@inotia00
Copy link
Owner

inotia00 commented Sep 1, 2024

Are you sure you are using YouTube 19.16.39?
On my side, I don't see this button even when I open the same video

@Kuddus73
Copy link
Author

Kuddus73 commented Sep 1, 2024

Are you sure you are using YouTube 19.16.39?

Yes.

I don't see this button even when I open the same video

Here:

Screen_Recording_20240901_074250_YouTube.mp4

@inotia00
Copy link
Owner

inotia00 commented Sep 1, 2024

If so, there is a possibility of A/B tests

This is not reproducible on my side, so I will remove Hide Use this sound button setting in the next dev release
(Anyway this is valid issue)

@inotia00 inotia00 reopened this Sep 1, 2024
@inotia00
Copy link
Owner

inotia00 commented Sep 1, 2024

Never mind, I can reproduce it on one of my Google accounts

Screen_Recording_20240901_032341_YouTube.mp4

This will be added as a Hide floating button setting
(Since this setting can hide other floating buttons besides Use this sound)

Screen_Recording_20240901_074250_YouTube.mp4

This will be integrated into the Hide Use this sound button setting

@Kuddus73 Kuddus73 changed the title bug: Hide Use this sound button doesn't work bug(YouTube): Hide Use this sound button doesn't work Sep 1, 2024
@inotia00 inotia00 changed the title bug(YouTube): Hide Use this sound button doesn't work bug(YouTube/Shorts components): Hide Use this sound button doesn't work Sep 1, 2024
inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Sep 1, 2024
@inotia00
Copy link
Owner

inotia00 commented Sep 1, 2024

reflected in revanced-patches-4.13.1-dev.3

@inotia00 inotia00 closed this as completed Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants