-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional tools for plugin archives: php-scoper, rector #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/build-plugin-archive.yml
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
…d-archives # Conflicts: # .github/workflows/build-plugin-archive.yml
Signed-off-by: Moritz Meißelbach <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
…tly downloads to the root folder again now
Signed-off-by: Moritz Meißelbach <[email protected]>
Signed-off-by: Moritz Meißelbach <[email protected]>
AlexP11223
reviewed
Jul 19, 2024
Biont
changed the title
Prefixed plugin archives via php-scoper
Additional tools for plugin archives: php-scoper, rector
Jul 25, 2024
tyrann0us
requested changes
Sep 3, 2024
Co-authored-by: Philipp Bammes <[email protected]>
tyrann0us
reviewed
Sep 3, 2024
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
breaking change in actions/upload-artifact Signed-off-by: Alex Pantechovskis <[email protected]>
Added |
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
tyrann0us
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating all the changes. Left a minor round of suggestions to get the new lines straight, but this doesn't stop me from approving.
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
Co-authored-by: Philipp Bammes <[email protected]> Signed-off-by: Moritz Meißelbach <[email protected]>
tyrann0us
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
The existing multi-step plugin archive workflow can currently identify and execute the following tools
inpsyde/composer-asset-compiler
inpsyde/wp-translation-downloader
What is the new behavior (if this is a feature change)?
In addition, the following "post-processing" tools are introduced
humbug/php-scoper
rectorphp/rector
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: